Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jormun]: Fix request_datetime in ridesharing #4321

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

kadhikari
Copy link
Contributor

@kadhikari kadhikari commented Nov 15, 2024

  • We use a tuple structure PeriodRxtremity('datetime', 'represents_start') to keep departure and arrival date_time.
  • Except InstantSystem, all the other ridesharing services do not have parameter wanted arrival date_time hence error is present for all of them.
  • The new structure RequestDates ('departure_datetime', 'arrival_datetime', 'represents_start') should be enough to manage all the ridesharing services (PeriodRxtremity should not be modified as it is used by other components also).

Ticket: https://navitia.atlassian.net/browse/NAV-3506

Copy link

sonarcloud bot commented Nov 15, 2024

@kadhikari kadhikari merged commit e3587c7 into dev Dec 10, 2024
9 checks passed
@kadhikari kadhikari deleted the fix_ridesharing_request_date branch December 10, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants